-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HDInsight]Add New API Version 2023-08-15-Preview #25135
Conversation
Hi, @xinlifoobar! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
applications.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
applications.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
cluster.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
cluster.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
configurations.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
configurations.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
extensions.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
extensions.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
locations.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
locations.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
operations.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
operations.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
privateEndpointConnections.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
privateEndpointConnections.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
privateLinkResources.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
privateLinkResources.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
scriptActions.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
scriptActions.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
virtualMachines.json | 2023-08-15-preview(b36f753) | 2021-06-01(main) |
virtualMachines.json | 2023-08-15-preview(b36f753) | 2023-04-15-preview(main) |
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) | new version | base version |
---|---|---|
package-2023-08-preview | package-2023-08-preview(b36f753) | default(main) |
The following errors/warnings exist before current PR submission:
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The JSON file has a circular reference. readme: specification/hdinsight/resource-manager/readme.md json: Microsoft.HDInsight/preview/2023-08-15-preview/scriptActions.json |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
Hi @xinlifoobar! The automation detected this pull request introduces changes to at least one existing API version that violate Azure's versioning policy. To comply with the policy, these changes must be made in a new API version. As a result, the automation added the
|
Hi @rkmanda. This is our preview API version and is not public yet. Could you please help us merge it? |
You need to follow the process described on #25135 (comment) to get an approval on the detection of the breaking changes |
Next Steps to Merge |
Hi @xinlifoobar! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
14789f0
to
0105f3f
Compare
Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
I tried OpenAPIHub but failed with below error so have to do this manually. I combined all in the same commit and hopefully this works. Thanks.
|
Done. |
0105f3f
to
b36f753
Compare
Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
Hi @xinlifoobar, I'd like to double confirm that the only change introduced between 2023-04-15-preview and 2023-08-15-preview is "outboundDependenciesManagedType"? |
I have to do this because this saves effort than bypassing the breaking change process. Also, there are a lot more works behind this enum value so it is better to be in a new api version. I could confirm there are no new changes in this version. |
/pr RequestMerge |
Swagger pipeline restarted successfully, please wait for status update in this comment. |
…view
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Getting help
and https://aka.ms/ci-fix.